Modify collection table to expose root collection as root #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackLewis-digirati
requested review from
donaldgray,
tomcrane,
p-kaczynski and
griffri
JackLewis-digirati
changed the title
donaldgray
approved these changes
Sep 20, 2024
src/IIIFPresentation/Test.Helpers/Integration/PresentationContextFixture.cs
Outdated
Show resolved
Hide resolved
griffri
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #23
This PR updates flat collections to refer to the root collection as root everywhere. This includes when gathering parent collections.
How this works is that the primary key of the
collectionstable has changed to a composite key ofcustomer idandid, meaning that the root record of the customer will always have an id ofroot. The knock-on effect of this is a simplification in how we work out the root collection, as there is now not a separate internal id that is referred to asrootby customers